Skip to content

fix(view): data attribute handling for x-component#2109

Merged
brendt merged 2 commits intotempestphp:3.xfrom
iamdadmin:3.x-fix-dynamic-component-data
Apr 9, 2026
Merged

fix(view): data attribute handling for x-component#2109
brendt merged 2 commits intotempestphp:3.xfrom
iamdadmin:3.x-fix-dynamic-component-data

Conversation

@iamdadmin
Copy link
Copy Markdown
Contributor

Closes #2000

  • Extended x-component to ensure it handles data, boolean and stringable attribute spread.
  • Added tests.

@iamdadmin iamdadmin requested a review from brendt as a code owner April 5, 2026 05:51
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 5, 2026

Benchmark Results

Comparison of 3.x-fix-dynamic-component-data against 3.x (6c8b9fefdf1a7c7cde6cecdfe9ae902883cc05c7).

Open to see the benchmark results

No benchmark changes above ±5%.

Generated by phpbench against commit f0e9912

@brendt brendt merged commit e80f5a7 into tempestphp:3.x Apr 9, 2026
76 checks passed
@brendt
Copy link
Copy Markdown
Member

brendt commented Apr 9, 2026

Looking good :)

@iamdadmin iamdadmin deleted the 3.x-fix-dynamic-component-data branch April 9, 2026 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dynamic components assume attributes to be string

2 participants